ws get_header bids stream draft - #483
Open
ninaiiad wants to merge 11 commits into
Open
Conversation
ltitanb
reviewed
Jul 28, 2026
Collaborator
|
I like the simplicity of per-slot streams vs the old PoC establishing long lived connections. Q is if handshake overhead is neglible or will be problematic / is this enough time for the relay to establish reliable RTTs? |
JasonVranek
reviewed
Jul 28, 2026
ltitanb
previously approved these changes
Aug 3, 2026
ltitanb
reviewed
Aug 3, 2026
ninaiiad
force-pushed
the
ng/ws-get-header
branch
3 times, most recently
from
August 3, 2026 19:50
fd8b6a2 to
fa466ca
Compare
ltitanb
previously approved these changes
Aug 3, 2026
ninaiiad
force-pushed
the
ng/ws-get-header
branch
from
August 4, 2026 08:51
fa466ca to
08b141a
Compare
ltitanb
previously approved these changes
Aug 4, 2026
gd-0
reviewed
Aug 6, 2026
JasonVranek
approved these changes
Aug 10, 2026
| "received new header from ws stream" | ||
| ); | ||
|
|
||
| validated?; |
Collaborator
There was a problem hiding this comment.
here and above at decode_ssz_payload(&bid_bytes, fork)?; we could exit early which could drop the info! and possibly record_status which may leave gaps when debugging. Worse is info! fires -> validation fails, since to a user the info looks like a success.
maybe can consider calling record_status only on the return result of get_header_ws
| let (mut stream, _) = match timeout_at(deadline, connect).await { | ||
| Ok(Ok(connected)) => connected, | ||
| Ok(Err(err)) => { | ||
| let rejected = match &err { |
Collaborator
There was a problem hiding this comment.
consider also checking res.body() so the reason for the error is surfaced not just the status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.